Skip to content

Fix LangChain capitalization in Japanese docs#23074

Open
yahonda wants to merge 5 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix/langchain-capitalization-ja
Open

Fix LangChain capitalization in Japanese docs#23074
yahonda wants to merge 5 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix/langchain-capitalization-ja

Conversation

@yahonda

@yahonda yahonda commented Jun 16, 2026

Copy link
Copy Markdown
Member

Fix katakana transliteration ラングチェーン → LangChain

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Japanese documentation to use the English term "LangChain" instead of its Katakana transliteration. The review feedback suggests addressing an incomplete Japanese sentence in the LangChain integration guide to ensure grammatical correctness, as well as standardizing other ecosystem integrations (like LlamaIndex and Jina AI) to English and removing redundant words in the 2024 release notes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ai/integrations/vector-search-integrate-with-langchain.md Outdated
Comment thread tidb-cloud/releases/release-notes-2024.md Outdated
@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackysp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yahonda and others added 2 commits June 16, 2026 10:40
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jun 16, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-06-16 03:26:57.812118247 +0000 UTC m=+1448918.882435637: ☑️ agreed by qiancai.

@qiancai

qiancai commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@yahonda, would you please resolve conflicts on this PR? Thanks.

@yahonda

yahonda commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

Conflicts have been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants