lake: incremental updates 0614#23059
Conversation
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
lilin90
added
translation/no-need
ti-chi-bot
Bot
added
the
size/S
lilin90
added
area/tidb-cloud
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request uncomments the Homebrew installation instructions for LakeSQL, adds a note about service hosting fees to the Data Integration overview, and introduces a new 'Service Hosting Pricing' section in the pricing and billing documentation. The reviewer provided several actionable suggestions to align the updated text with the style guide, specifically recommending the use of active voice instead of passive voice and ensuring consistent terminology across the documentation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| ### Service Hosting Pricing | ||
|
|
||
| Service hosting fees apply to the Data Integration service. Unlike a warehouse, a Data Integration service typically runs continuously (24/7) until you stop it. Billing follows the same model as warehouses: it is calculated on a **per-second basis** according to the actual running time, and the price depends on the service size and the {{{ .lake }}} edition you use. |
There was a problem hiding this comment.
The sentence uses passive voice ("it is calculated on a per-second basis"). Rewriting it to active voice makes the billing explanation clearer and more direct.
| Service hosting fees apply to the Data Integration service. Unlike a warehouse, a Data Integration service typically runs continuously (24/7) until you stop it. Billing follows the same model as warehouses: it is calculated on a **per-second basis** according to the actual running time, and the price depends on the service size and the {{{ .lake }}} edition you use. | |
| Service hosting fees apply to the Data Integration service. Unlike a warehouse, a Data Integration service typically runs continuously (24/7) until you stop it. Billing follows the same model as warehouses: {{{ .lake }}} calculates fees on a **per-second basis** based on the actual running time, and the price depends on the service size and the {{{ .lake }}} edition you use. |
References
- Avoid passive voice overuse. (link)
|
|
||
| Service hosting fees apply to the Data Integration service. Unlike a warehouse, a Data Integration service typically runs continuously (24/7) until you stop it. Billing follows the same model as warehouses: it is calculated on a **per-second basis** according to the actual running time, and the price depends on the service size and the {{{ .lake }}} edition you use. | ||
|
|
||
| Service sizes are derived from the Warehouse XSmall. The monthly cost shown below is an estimate based on continuous 24/7 operation (720 hours per month, assuming one month is calculated as 30 days) and is provided for reference only. |
There was a problem hiding this comment.
The sentence uses passive voice ("are derived from", "is calculated", "is provided"). Rewriting it to active voice improves clarity and readability.
| Service sizes are derived from the Warehouse XSmall. The monthly cost shown below is an estimate based on continuous 24/7 operation (720 hours per month, assuming one month is calculated as 30 days) and is provided for reference only. | |
| Service sizes are based on the XSmall warehouse size. The monthly cost shown below is an estimate based on continuous 24/7 operation (720 hours per month, assuming a 30-day month) and serves as a reference only. |
References
- Avoid passive voice overuse. (link)
There was a problem hiding this comment.
@awxxxxxx Please review the content updates in this pricing doc.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/S
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
lilin90
added
the
do-not-merge/hold
1 participant
What is changed, added or deleted? (Required)
homebrew-tapsince https://github.com/tidbcloud/homebrew-tap is open-source now.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?