Skip to content

Conversation

@breezewish
Copy link
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Inference service support customizing OpenAI API Base
  • Fixed incorrect example of JINA

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

* origin/release-8.5: (48 commits)
  Terraform: remove `cluster_id` in `cluster_id, vpc_peering_id` (#22318)
  Update the Compatibility changes of release-8.5.4 (#22233) (#22316)
  cloud: optimize the description of TiDB-X features (#22294)
  Add FORMAT keyword to import statement options (#22301) (#22304)
  cloud: delete disaster recovery (#22299)
  v8.5.4 tikv: update default settings of `server.grpc-concurrency` and `server.grpc-raft-conn-num`. (#22273) (#22298)
  Update create-tidb-instance-premium.md (#22288)
  sync-diff-inspector: add PROCESS permission when upstream and downstream are TiDB (#22289) (#22292)
  sql-faq: fix outdated description about JDBC (#22283) (#22287)
  master, v8.5: update download URL from pingcap.org to pingcap.com (#22240) (#22280)
  tikv: fix the default value of `end-point-memory-quota` (#22271) (#22272)
  v8.5.4: tikv: update auto compaction config (#22251) (#22265)
  pdf: update year to 2026 in copyright.tex (#22253) (#22260)
  v8.5.4 tikv: update rocksdb.max-manifest-file-size default value (#21689) (#22250)
  tidb-cloud: update the RU definition (#22197)
  cloud: update backup policies and execution rules (#22227)
  cloud: add release notes for 20251230 (#22247)
  cloud: add private link connection docs for overview and Confluent (#22246)
  tiproxy: add tiproxy usage in the tidb cloud doc (#21483)
  cloud: update the retention note for the latest automatic backup (#22248)
  ...
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Jan 13, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @breezewish, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of the inference service by allowing users to specify a custom API base for OpenAI embedding models, primarily to support Azure OpenAI deployments. It also refines existing documentation examples for both JINA AI and OpenAI embeddings, ensuring they reflect current best practices regarding vector dimensions and model choices. The changes aim to improve compatibility and provide clearer guidance for integrating various embedding services.

Highlights

  • OpenAI API Base Customization: The inference service now supports customizing the OpenAI API Base URL, specifically enabling integration with Azure OpenAI services.
  • JINA Embedding Example Correction: The example for JINA AI embeddings has been updated to correctly use a VECTOR(2048) dimension.
  • OpenAI Embedding Model Update: The OpenAI embedding example has been upgraded to use the text-embedding-3-large model with a VECTOR(3072) dimension, replacing the previous text-embedding-3-small model and VECTOR(1536) dimension.
  • Azure OpenAI Configuration Guide: New documentation has been added detailing how to configure and use Azure OpenAI embedding models by setting the TIDB_EXP_EMBED_OPENAI_API_BASE global variable.
  • API Base Security Note: A security note has been included, clarifying that the TIDB_EXP_EMBED_OPENAI_API_BASE is restricted to Azure OpenAI or official OpenAI URLs, with arbitrary base URLs being forbidden.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 13, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for Jina AI and OpenAI embeddings. It correctly updates the vector dimensions for a Jina AI example and introduces a new section for using Azure OpenAI, including how to customize the API base URL. The changes are valuable, but I've identified a few minor typos and areas for improved clarity in the new content. My review includes specific suggestions to address these points, ensuring the documentation is as clear and accurate as possible for users.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants