Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 369 418 +49
Branches 132 150 +18
=========================================
+ Hits 369 418 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjohansebas
left a comment
There was a problem hiding this comment.
Okay, the code looks good. Could you please update the README?
|
Is it possible to also add other common valid URL characters like |
Absolutely, this was just a scaffold to start iterating on but I can add them to the PR. One open question on
Depends on if we're supporting repeat/optional features. If so, yes, they'd need to be escaped. That's where using a regex to validate completely breaks down and, with repeats, a ReDoS vector opens so it's a more complex PR. |
Extremely simple version of #380, meant to be a starting point for more iteration on the actual regex allowed.