Skip to content

Add DOMException mention to DOM error sections#5261

Merged
ndossche merged 1 commit intophp:masterfrom
lacatoire:fix/dom-normalize-error-sections
Mar 2, 2026
Merged

Add DOMException mention to DOM error sections#5261
ndossche merged 1 commit intophp:masterfrom
lacatoire:fix/dom-normalize-error-sections

Conversation

@lacatoire
Copy link
Member

@lacatoire lacatoire commented Feb 5, 2026

Fixes #4225

Add an introductory sentence mentioning DOMException to error sections that list error codes without context.

Happy to adjust if needed.

@lacatoire lacatoire requested a review from ndossche as a code owner February 5, 2026 10:43
Copy link
Member

@ndossche ndossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lacatoire lacatoire changed the title Normalize DOM error sections to explicitly mention DOMException Add DOMException mention to DOM error sections Mar 2, 2026
@lacatoire lacatoire closed this Mar 2, 2026
@ndossche
Copy link
Member

ndossche commented Mar 2, 2026

Was this merged or just closed? I don't see the merge

@lacatoire lacatoire reopened this Mar 2, 2026
@ndossche
Copy link
Member

ndossche commented Mar 2, 2026

@lacatoire Do you have merge rights?

@lacatoire
Copy link
Member Author

@ndossche nop, but I'd like that.

@ndossche ndossche merged commit 7d5c74c into php:master Mar 2, 2026
3 checks passed
@ndossche
Copy link
Member

ndossche commented Mar 2, 2026

I see, I thought you had merge right which is why I didn't merge this myself earlier (since you're listed as "member").

@lacatoire lacatoire deleted the fix/dom-normalize-error-sections branch March 3, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Normalize error sections in DOM

2 participants