Delegates adapter creation back to php-db/phpdb #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates existing test Signed-off-by: Joey Smith <[email protected]> Signed-off-by: Joey Smith <[email protected]>
tyrsson
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates existing test
Signed-off-by: Joey Smith [email protected]
Signed-off-by: Joey Smith [email protected]
Description
This delegates Adapter creation back to the phpdb package.
Reason:
Due to the way ConfigAggregator works and laminas component installer we have no way to control the order in which the providers are written to the config array for Mezzio. Since this change unifies adapter creation for both standard adapter creation (single adapter) or Named adapter config and adapter packages are only providing the underlying dependency instances it will no longer matter which order the packages are listed as in the config.
Note:
All dependencies are aliased to their respective interfaces and each adapter will be expected to provide the required mapping for each Driver instance they expose. The creation context hinges on which Driver instance is passed in the adapters configuration.