2.4.22 bugfix release #1094
Open
2.4.22 bugfix release #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a pblum-mode bug. The median value for scaling was not computed correctly before -- it used a full array of fluxes instead just of the reference flux. The code was also simplified as I worked through the logic to understand what's going on. Third light parts have also been updated but not yet tested. All tests pass. * Adds an explicit model arg to compute_l3s(). This commit catches the circumstance when pblum_mode='dataset-scaled' but no model is passed, which caused the returned l3s to be in absolute units. This makes no contextual sense for the user. A warning is also issued when both model and use_pblums is passed -- pblums take precedence and model is ignored. This closes #1085. Two stale debug print statements from the previous commit have been removed. A thorough, claude-generated compute_l3s test has been added to the test suite. * Names arguments to set_value. Co-authored-by: Kyle Conroy <kyleconroy@gmail.com> * Names arguments to set_value. Co-authored-by: Kyle Conroy <kyleconroy@gmail.com> * Apply suggestions from code review Co-authored-by: Kyle Conroy <kyleconroy@gmail.com> * Removes a debugging relic that caused checks to be skipped needlessly. * Reverts file rename, renames a function instead. Also makes Kyle happy. ;) * ChangeLog updates. --------- Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #771
closes #1086