modularisiation of ClassBuilder#19570
Open
NathanMalenge wants to merge 15 commits intopharo-project:Pharo14from
Open
modularisiation of ClassBuilder#19570NathanMalenge wants to merge 15 commits intopharo-project:Pharo14from
NathanMalenge wants to merge 15 commits intopharo-project:Pharo14from
Conversation
NathanMalenge
force-pushed
the
classBuilder
branch
from
ad14f61 to
b4e856f
Compare
Member
|
@NathanMalenge , next week would you mind discussions with @MarcusDenker what's the best way to make the test pass? |
Collaborator
Author
|
@guillep sure ! |
Member
|
I think you can for now remove testBuildingClassesWithSlotsClassifiesItsMethods, I will then check how to test what it checks without referencing BooleanSlot |
…replaced TViewModel with an existing mock
Collaborator
Author
|
finally, all tests are green !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ClassBuilder in the jenkinsFile