modularisation FileSystem#19568
Open
NathanMalenge wants to merge 29 commits intopharo-project:Pharo14from
Open
modularisation FileSystem#19568NathanMalenge wants to merge 29 commits intopharo-project:Pharo14from
NathanMalenge wants to merge 29 commits intopharo-project:Pharo14from
Conversation
Moved the two tests in a dedicated class. To remove the dependency between the two packages FileSystem-Core-Tests and Collctions-String-Tests
…dependency problem
guillep
reviewed
Apr 17, 2026
| group: 'Tests' with: { 'FileSystem-Core-Tests'. 'FileSystem-Disk-Tests'. 'FileSystem-Tests-Attributes' } ] | ||
| group: 'Core' with: { 'FFI-Kernel'. 'FileSystem-Path'. 'FileSystem-Core'. 'FileSystem-Disk'. 'System-Sources-Files'}; | ||
| group: 'Tests' with: { 'FileSystem-Core-Tests'. 'FileSystem-Disk-Tests'. 'FileSystem-Tests-Attributes' } ; | ||
| group: 'TestsWithFFI' with: #('Tests' 'UnifiedFFI').] |
Member
There was a problem hiding this comment.
Instead of a different group, we should say that FileSystem-Core-Tests depends on UnifiedFFI, right?
Member
|
Looks like BaselineOfUnifiedFFI misses a dependency to OSPlatforms!! :} |
Collaborator
Author
|
I’ll check that on monday, thx for the guidance @guillep |
…imal in the baseline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added FileSystem in the jenkinsFile