#19461 Rework Shout Preferences

[belaroesener]

I reorganized the Shout Preferences around the predefined styles already available, adding two special styles Custom and Default.
Default represents the style for the currently selected UI Theme and will change if the UI Theme changes.
Custom represents the style editable via the SettingBrowser and can be initialized by copying it from any of the other styles.

I fixed the problems described in #19461:

• With the new system, when loading a UI Theme, the current style is only changed to the Theme default, if the currently selected style is Default
• I send #themeChanged to the world whenever any of the style elements is changed in the SettingBrowser. This works but I would be happy for any suggestions to make it work better, as this solution seems somewhat inefficient.
• I replaced SHStyleElement with two new classes, that manage the state in a different way, and do not exhibit the same problems.
• The emphasis bold italic now works

[jecisc]

@demarey and @estebanlm are currently working on the SettingBrowser.

Maybe they can be interested to review this PR

[estebanlm]

is this working in the context of the new settings browser ?

[Ducasse]

It feels like a typo

[Ducasse]

Hi belaroesener

If you have some cycles for another PR after we integrate this one.
I would love to see all the symbols used in all Shout turned into strings because these symbols are unnecessary and polutes de symbol space.
This is on my todo but it is kind of infinite in this moment.

Tx

[belaroesener]

is this working in the context of the new settings browser ?

This PR addresses the Issues I had with the old settings browser. I had not followed the development of the new setting browser, but now I am realizing that it is the default Browser in Pharo14? (I always use CMD-, to open the settings browser, but this still opens the old browser).

The style elements use special widgets, from my understanding the logic used by the new browser is a bit different for this. I'll look into it

[belaroesener]

Hi belaroesener

If you have some cycles for another PR after we integrate this one. I would love to see all the symbols used in all Shout turned into strings because these symbols are unnecessary and polutes de symbol space. This is on my todo but it is kind of infinite in this moment.

Tx

Sure, could you elaborate a bit on what symbols you mean?

[jecisc]

I think he is refering to the methods with the pragma #styleTable:

For example:

^ #(
			(default 								('657A81' muchDarker))
			...
)

This will create symbols. He would like it to become

^ #(
			('default' 								('657A81' muchDarker))
			...
)

This is what I understood. Maybe Steph can confirm

[Ducasse]

Yes I refered to this list of symbols.

[Ducasse]

Hello did you see my comment? cutom has a typo.

[belaroesener]

@Ducasse Yes, it's a typo. Thanks, I'll fix it.

[Ducasse]

Thanks. Can you check the conflict?