Fix browse commit in iceberg repository.#19388
Open
AlexisCnockaert wants to merge 2 commits intopharo-project:Pharo14from
Open
Fix browse commit in iceberg repository.#19388AlexisCnockaert wants to merge 2 commits intopharo-project:Pharo14from
AlexisCnockaert wants to merge 2 commits intopharo-project:Pharo14from
Conversation
I implemented missing method and check directly for `RGComment` to not have red squares. Fixes pharo-project#19350
Ducasse
reviewed
Mar 7, 2026
| @@ -19,7 +19,7 @@ ClyClassTableDecorator class >> decorateTableCell: anItemCellMorph of: aDataSour | |||
| labelMorphExtension := anItemCellMorph label assureExtension. | |||
| cmt := aDataSourceItem actualObject comment. | |||
|
|
|||
Member
There was a problem hiding this comment.
when is the case that cmt does not understand content?
Could not we get all objects returned there to understand comment (I mean solving the cause instead of the consequence)?
Collaborator
Author
|
I mean besides RGComment, every objects are strings (class comments) so... |
Collaborator
Author
|
The content block is only for RGComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented missing method and check directly for
RGCommentto not have red squares.Fixes #19350