Generic nonViolators for ReConditions (retry)#18649
Closed
carolahp wants to merge 4 commits intopharo-project:Pharo14from
Closed
Generic nonViolators for ReConditions (retry)#18649carolahp wants to merge 4 commits intopharo-project:Pharo14from
carolahp wants to merge 4 commits intopharo-project:Pharo14from
Conversation
…pharo into refactor/generic-non-violatos3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces PR#18645
Please merge before PR#18597
This is a follow up from @balsa-sarenac comment in PR#18597
This PR is the first step to implement a generic method nonViolators for conditions.
To do so I have introduced the accessor subjects in conditions. Subjects are candidates to be violators.
Normally subjects should be overriden only by abstract classes such as ReClassesCondition or ReMethodsCondition, because their subclasses handle different kinds of violators (i.e.: classes and methods). However there are exceptions (check ReClassesExistCondition). This, nonViolators are computed as the difference between subjects and violators.
I added tests for all subclasses of ReClassesCondition , where I check for nonViolators and also for the condition's error string.
By overriding subjects, negated conditions can also use the generic implementation of nonViolators.
More tests for complex conditions are required