Skip to content

Conversation

@prashsti29
Copy link

@prashsti29 prashsti29 commented Jan 19, 2026

Fixes # .

Changes proposed in this pull request:

  • Add Prashsti Asthana to contributors

@pgRouting/admins

Summary by CodeRabbit

Release Notes

  • Chores

    • Version bumped to 4.1.0-dev
    • Updated GitHub Actions workflow tooling
    • Updated build infrastructure and testing dependencies
  • Documentation

    • Added release notes structure for version 4.1.0
    • Updated version metadata across all documentation and localization files
    • Added contributor to documentation

✏️ Tip: You can customize this high-level summary in your review settings.

krashish8 and others added 10 commits November 8, 2025 00:50
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…elop/actions/checkout-6

Bump actions/checkout from 5 to 6
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Co-authored-by: Weblate <[email protected]>
Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/
Translation: pgRouting/pgRouting
…g-develop

Translations update from OSGeo Weblate
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

Walkthrough

Version bump from pgRouting 4.0.0 to 4.1.0 across build configuration, GitHub Actions workflows, SQL signatures, documentation, localization files, and test infrastructure. Updated GitHub Actions checkout action from v5 to v6 throughout CI/CD pipelines.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Updates
.github/workflows/boost_version.yml, centos.yml, check-files.yml, check-queries.yml, clang.yml, doc-check.yml, macos.yml, release.yml, ubuntu.yml, update-locale.yml, website.yml
Updated actions/checkout from v5 to v6 across all CI/CD workflows. No logic changes; action version bump only.
Version Configuration & Build
CMakeLists.txt, .github/workflows/update.yml
Updated project version from 4.0.0 to 4.1.0, set PROJECT_VERSION_DEV to "-dev", added 4.1 to MINORS list, added 4.0.0 to OLD_SIGNATURES list, and expanded test matrix.
SQL Signatures & Functions
sql/sigs/pgrouting--4.1.sig, sql/coloring/sequentialVertexColoring.sql, sql/scripts/build-extension-update-files.pl
Created comprehensive 4.1 signature file with ~330+ SQL function declarations across graph algorithms, routing, and utility functions. Updated version tags and added 4.1 version constant to build script.
Documentation & Release Notes
NEWS.md, doc/src/pgRouting-introduction.rst, doc/src/release_notes.rst, doc/_static/page_history.js
Added 4.1 release notes section, updated version array to include 4.1, added contributor "Prashsti Asthana", and updated introductory documentation.
Localization Files
locale/de/LC_MESSAGES/index.po, locale/en/LC_MESSAGES/..., locale/es/..., locale/ja/..., locale/ko/..., locale/pot/..., locale/sv/..., locale/zh_Hans/...
Updated project version metadata from v3.8/v4.0 to v4.1 across all locale headers (PO/POT files). Added 4.1 release notes translations and corrected contributor names.
Test & Version Output
docqueries/version/full_version.result, docqueries/version/version.result
Updated expected version output from 4.0.0 to 4.1.0-dev in test result files.
Developer Scripts
tools/developer/pumpup_version.sh, tools/developer/run.sh, tools/testers/pg_prove_tests.sh
Updated test database setup to use 4.1.0, restored processing of dijkstra subdirectories, and corrected file reference in version-bump script.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

The changes are predominantly repetitive version number updates and GitHub Actions maintenance across many files. The new SQL signature file is large but consists entirely of function declarations without executable logic. While the file count is high, the consistency and pattern-based nature of the modifications reduce complexity. Key verification points: confirm all version references are consistently updated to 4.1.0, validate signature file completeness, and check locale file synchronization.

Possibly related PRs

  • Week 5 king and minimumdegree ordering #461 — Updates ordering function implementations and type signatures (II_t_rt → int64_t) that align with pgr_kingOrdering and pgr_minDegreeOrdering additions in the 4.1 signature file.
  • Week 5 sloan ordering #460 — Modifies sloan ordering function signatures and implementations that correspond to pgr_sloanordering declarations in the new pgrouting--4.1.sig file.

Suggested reviewers

  • cvvergara
  • robe2
  • sanak

Poem

🐰 Version four point one hops into place,
GitHub Actions updated with grace,
Signatures sprawl like a warren so wide,
Locale files gleam with multilingual pride,
A bump that's consistent from top to the base! 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'Add Prashsti Asthana to contributors' is directly related to one specific change in the diff (adding a contributor name to the documentation), but the changeset is substantially broader, including a complete version upgrade from 4.0.0 to 4.1.0, GitHub Actions updates, and numerous SQL function declarations. The title should reflect the primary purpose of this release PR, such as 'Release pgRouting 4.1.0' or 'Bump version to 4.1.0', as the version upgrade and related changes represent the main scope of the PR, not the contributor addition.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@locale/pot/pgrouting_doc_strings.pot`:
- Around line 13498-13507: Replace the placeholder "No changes yet" msgid entry
in the translation template (the msgid "No changes yet" near the pgRouting 4.1.0
Release Notes block) with the actual release notes content or remove that msgid
entry entirely before publishing; ensure the msgstr is populated with the final
release text (or delete the whole msgid/msgstr pair) so the 4.1.0 release notes
in the template no longer contain the placeholder.
♻️ Duplicate comments (3)
.github/workflows/clang.yml (1)

58-58: Same checkout v6 bump as other workflows.

Please ensure this is covered by the same verification already requested.

.github/workflows/ubuntu.yml (1)

43-43: Same checkout v6 bump as other workflows.

Please ensure this is covered by the same verification already requested.

.github/workflows/macos.yml (1)

51-51: Same checkout v6 bump as other workflows.

Please ensure this is covered by the same verification already requested.

🧹 Nitpick comments (1)
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (1)

16149-16163: Consider replacing the “No changes yet” placeholder before the 4.1.0 release.
If this section is intended for a public release note, adding real entries will avoid shipping empty notes.

Comment on lines +13498 to +13507
msgid "pgRouting 4.1"
msgstr ""

msgid "pgRouting 4.1.0 Release Notes"
msgstr ""

msgid "To see all issues & pull requests closed by this release see the `Github milestone for 4.1.0 <https://github.com/pgRouting/pgrouting/issues?utf8=%E2%9C%93&q=milestone%3A%22Release%204.1.0%22>`__"
msgstr ""

msgid "No changes yet"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Replace the placeholder release notes before publishing.

Line 13507 reads “No changes yet”. If 4.1.0 is being published, this should be replaced with actual changes or the section should be omitted until it’s ready.

🤖 Prompt for AI Agents
In `@locale/pot/pgrouting_doc_strings.pot` around lines 13498 - 13507, Replace the
placeholder "No changes yet" msgid entry in the translation template (the msgid
"No changes yet" near the pgRouting 4.1.0 Release Notes block) with the actual
release notes content or remove that msgid entry entirely before publishing;
ensure the msgstr is populated with the final release text (or delete the whole
msgid/msgstr pair) so the 4.1.0 release notes in the template no longer contain
the placeholder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants