-
-
Notifications
You must be signed in to change notification settings - Fork 59
Add Prashsti Asthana to contributors #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…elop/actions/checkout-6 Bump actions/checkout from 5 to 6
pumpup to 4.1.0 dev
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Co-authored-by: Weblate <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/ Translation: pgRouting/pgRouting
…g-develop Translations update from OSGeo Weblate
WalkthroughVersion bump from pgRouting 4.0.0 to 4.1.0 across build configuration, GitHub Actions workflows, SQL signatures, documentation, localization files, and test infrastructure. Updated GitHub Actions checkout action from v5 to v6 throughout CI/CD pipelines. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes The changes are predominantly repetitive version number updates and GitHub Actions maintenance across many files. The new SQL signature file is large but consists entirely of function declarations without executable logic. While the file count is high, the consistency and pattern-based nature of the modifications reduce complexity. Key verification points: confirm all version references are consistently updated to 4.1.0, validate signature file completeness, and check locale file synchronization. Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@locale/pot/pgrouting_doc_strings.pot`:
- Around line 13498-13507: Replace the placeholder "No changes yet" msgid entry
in the translation template (the msgid "No changes yet" near the pgRouting 4.1.0
Release Notes block) with the actual release notes content or remove that msgid
entry entirely before publishing; ensure the msgstr is populated with the final
release text (or delete the whole msgid/msgstr pair) so the 4.1.0 release notes
in the template no longer contain the placeholder.
♻️ Duplicate comments (3)
.github/workflows/clang.yml (1)
58-58: Same checkout v6 bump as other workflows.Please ensure this is covered by the same verification already requested.
.github/workflows/ubuntu.yml (1)
43-43: Same checkout v6 bump as other workflows.Please ensure this is covered by the same verification already requested.
.github/workflows/macos.yml (1)
51-51: Same checkout v6 bump as other workflows.Please ensure this is covered by the same verification already requested.
🧹 Nitpick comments (1)
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (1)
16149-16163: Consider replacing the “No changes yet” placeholder before the 4.1.0 release.
If this section is intended for a public release note, adding real entries will avoid shipping empty notes.
| msgid "pgRouting 4.1" | ||
| msgstr "" | ||
|
|
||
| msgid "pgRouting 4.1.0 Release Notes" | ||
| msgstr "" | ||
|
|
||
| msgid "To see all issues & pull requests closed by this release see the `Github milestone for 4.1.0 <https://github.com/pgRouting/pgrouting/issues?utf8=%E2%9C%93&q=milestone%3A%22Release%204.1.0%22>`__" | ||
| msgstr "" | ||
|
|
||
| msgid "No changes yet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the placeholder release notes before publishing.
Line 13507 reads “No changes yet”. If 4.1.0 is being published, this should be replaced with actual changes or the section should be omitted until it’s ready.
🤖 Prompt for AI Agents
In `@locale/pot/pgrouting_doc_strings.pot` around lines 13498 - 13507, Replace the
placeholder "No changes yet" msgid entry in the translation template (the msgid
"No changes yet" near the pgRouting 4.1.0 Release Notes block) with the actual
release notes content or remove that msgid entry entirely before publishing;
ensure the msgstr is populated with the final release text (or delete the whole
msgid/msgstr pair) so the 4.1.0 release notes in the template no longer contain
the placeholder.
Fixes # .
Changes proposed in this pull request:
@pgRouting/admins
Summary by CodeRabbit
Release Notes
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.