Skip to content

Fix Makefile PG version check breaking on pre-release versions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maqeel75 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Makefile PG version check breaking on pre-release versions #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,17 @@ endif
include $(PGXS)

# Version compatibility check
pg_version_num := $(shell $(PG_CONFIG) --version | sed 's/^PostgreSQL *//' | \
sed 's/\([0-9]*\)\.\([0-9]*\).*/\1\2/')
# Extract only the leading major version integer. This must cope with
# pre-release strings such as "PostgreSQL 19beta1 (Ubuntu 19~beta1-1.noble)"
# where there is no MAJOR.MINOR dot; a dotted regex would leave the whole
# descriptive string (including the "(...)" suffix) in place and break the
# shell test below under dash (/bin/sh on Debian/Ubuntu).
pg_version_num := $(shell $(PG_CONFIG) --version | sed -E 's/^PostgreSQL ([0-9]+).*/\1/')

# Ensure we're building for PostgreSQL 14+
check-pg-version:
@echo "Building for PostgreSQL version: $(shell $(PG_CONFIG) --version)"
@if [ $(pg_version_num) -lt 14 ]; then \
@if [ "$(pg_version_num)" -lt 14 ]; then \
echo "Error: PostgreSQL 14 or later is required"; \
exit 1; \
fi
Expand Down
Loading