Invalidate viewer session before loading table#2958
Merged
texodus merged 1 commit intoperspective-dev:masterfrom Mar 20, 2025
Merged
Invalidate viewer session before loading table#2958texodus merged 1 commit intoperspective-dev:masterfrom
texodus merged 1 commit intoperspective-dev:masterfrom
Conversation
tomjakubowski
force-pushed
the
bugfix/viewer-error-recovery
branch
8 times, most recently
from
83859ae to
658647e
Compare
This fixes a bug where a failed `viewer.load()` call would poison the viewer and prevent it from loading any more tables. Signed-off-by: Tom Jakubowski <tom@prospective.dev>
tomjakubowski
force-pushed
the
bugfix/viewer-error-recovery
branch
from
658647e to
a1256f4
Compare
tomjakubowski
changed the title
texodus
approved these changes
Mar 20, 2025
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a failed
viewer.load()call would poison the viewer and prevent it from loading any more tables.