Merged
Conversation
1. Reserve vocabs while loading arrows into perspective to prevent overgrowth. 2. Free data tables and protobuf messages before processing the table to minimize the concurrent copies of the data in memory. Signed-off-by: Timothy Bess <[email protected]>
timbess
force-pushed
the
feature/decrease-max-heap-loading-data
branch
from
e0f7436 to
47f1672
Compare
texodus
approved these changes
Feb 1, 2025
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good!
We should consider adding heap benchmarks to our benchmark suite.
| @@ -1061,16 +1064,16 @@ Table::from_cols( | |||
| << dtype_to_str(data_table.get_column(col_name)->get_dtype()) | |||
Member
There was a problem hiding this comment.
This should be data_table->get_column also, but did not cause a compile error in CI because it is only compiled in debug builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a couple of places where we're overallocating.