Skip to content

[FEATURE] Add JsonQuery support - #249

Merged
Nexucis merged 2 commits into
perses:mainfrom
Gladorme:fix/json-query
Aug 25, 2026
Merged

[FEATURE] Add JsonQuery support#249
Nexucis merged 2 commits into
perses:mainfrom
Gladorme:fix/json-query

Conversation

@Gladorme

@Gladorme Gladorme commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Fixing/updating #230 PR

Screenshots

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

adrianSepiol and others added 2 commits August 24, 2026 16:12
@adrianSepiol @Gladorme
[FEATURE] Add JsonQuery support
d5389d1 
Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>
@Gladorme
[IGNORE] Fix JsonQuery support
e491a1d 
Bump @perses-dev/spec to 0.3.0-beta.4 (npm packages, module federation
shared config and CUE module) as JsonData and the JsonQuery entry of
QueryType are only available from 0.3.0-beta.3 onwards. Without it
type-check and build fail.

Also document the new JsonQuery model/runtime API and type the runtime
query context with JsonQueryContext, to stay aligned with the other
query plugin kinds.

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme
Gladorme marked this pull request as ready for review August 24, 2026 14:41
@Gladorme
Gladorme requested review from a team and AntoineThebaud as code owners August 24, 2026 14:41
Nexucis
Nexucis approved these changes Aug 24, 2026
View reviewed changes

@Nexucis Nexucis left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if you are fine with the changes that @adrianSepiol made @Gladorme

@celian-garcia celian-garcia mentioned this pull request Aug 24, 2026
Closed
6 tasks
@Nexucis
Nexucis merged commit 38a836b into perses:main Aug 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nexucis Nexucis Nexucis approved these changes
@AntoineThebaud AntoineThebaud Awaiting requested review from AntoineThebaud AntoineThebaud is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gladorme @Nexucis @adrianSepiol