Fixed indentation for proxysql image pull secrets#811
Fixed indentation for proxysql image pull secrets#811valmiranogueira merged 2 commits intopercona:mainfrom
Conversation
JustInVTime
requested review from
eleo007,
hors,
jvpasinatto,
nmarukovich and
valmiranogueira
as code owners
|
|
| {{- if $proxysql.imagePullSecrets }} | ||
| imagePullSecrets: | ||
| {{- $proxysql.imagePullSecrets | toYaml | indent 6 }} | ||
| {{ $proxysql.imagePullSecrets | toYaml | indent 6 }} |
There was a problem hiding this comment.
In order to not rely on how it's indented on template functions, the optimal solution would be:
{{- $proxysql.imagePullSecrets | toYaml | nindent 6 }}
And keep template indentation for readability
jvpasinatto
left a comment
jvpasinatto
left a comment
There was a problem hiding this comment.
Please bump the chart chart version:version: 1.19.1 in pxc-db/Chart.yaml
JustInVTime
force-pushed
the
fix-proxysql-pull-secrets
branch
from
822845b to
d05efa3
Compare
done |
|
README with newser chart version also need to be updated: |
done |
JustInVTime
force-pushed
the
fix-proxysql-pull-secrets
branch
from
d05efa3 to
4553acb
Compare
charts/pxc-db/Chart.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| apiVersion: v2 | |||
| appVersion: 1.19.0 | |||
| appVersion: 1.19.1 | |||
There was a problem hiding this comment.
Actually lint failed, cause chart version needs bump, app versions stay the same
There was a problem hiding this comment.
My bad, should be fixed now
There was a problem hiding this comment.
But please keep 1.19.0 as appVersion, since this is the version of released operator
JustInVTime
force-pushed
the
fix-proxysql-pull-secrets
branch
from
4553acb to
9f4f546
Compare
JustInVTime
force-pushed
the
fix-proxysql-pull-secrets
branch
from
9f4f546 to
5c4c382
Compare
4 participants
When using pull secrets for the proxysql image, the indentation is wrong. This fixes it