PBM-843 Improve error handling for inMemory storage engine#1269
Open
Anuja888 wants to merge 1 commit intopercona:devfrom
Open
PBM-843 Improve error handling for inMemory storage engine#1269Anuja888 wants to merge 1 commit intopercona:devfrom
Anuja888 wants to merge 1 commit intopercona:devfrom
Conversation
Add error handling for unsupported inMemory backupCursor
|
|
radoslawszulgo
changed the title
jcechace
requested changes
Feb 18, 2026
Collaborator
jcechace
left a comment
jcechace
left a comment
There was a problem hiding this comment.
Thank you for you contribution! I left some comments for you to look into.
| } | ||
| if err != nil { | ||
| // Detect inMemory engine unsupported backupCursor | ||
| if strings.Contains(err.Error(), "$backupCursor") { |
Collaborator
There was a problem hiding this comment.
This is extremely brittle and potentially dangerous -- it's quite generic so it could swallow the later checks.
Comment on lines
+97
to
+107
| if err != nil { | ||
| // Detect inMemory engine unsupported backupCursor | ||
| if strings.Contains(err.Error(), "$backupCursor") { | ||
| return nil, errors.New("physical backup is not supported for the inMemory storage engine") | ||
| } | ||
|
|
||
| se, ok := err.(mongo.ServerError) | ||
| if !ok { | ||
| return nil, err | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
It looks like formatting was broken by mistake.
Easy fix by running go fmt ./... from project root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses PBM-843 by improving error handling when attempting
physical backups on MongoDB instances running with the inMemory storage engine.
If the
$backupCursorstage is not supported, PBM now returns aclear and user-friendly message:
"physical backup is not supported for the inMemory storage engine"
All existing tests pass locally using Docker and go test.