Fix Spanish translations, typos, and syntax#1300
Open
ArtemioPadilla wants to merge 1 commit intopcottle:mainfrom
Open
Fix Spanish translations, typos, and syntax#1300ArtemioPadilla wants to merge 1 commit intopcottle:mainfrom
ArtemioPadilla wants to merge 1 commit intopcottle:mainfrom
Conversation
errors
- Fix translation typo in relativeRefs.js: 'memorabledi' →
'memorable'
- Fix 9 syntax errors: missing commas before pt_BR locale
entries in remote levels
- Fix 4 contraction typos in English comments
(arent/didnt/hasnt/wont)
- Improve Spanish (es_MX) translations across multiple
remote levels
- Fix various translation quality issues in strings.js
- Add comprehensive es_MX translations to remote tutorial
levels
Files affected:
- Remote levels: pull, push, fetchRebase, lockedMain,
mergeManyFeatures,
pushArgs, pushArgs2, pushManyFeatures, sourceNothing,
tracking
- Core files: strings.js, multiple level files
- Code quality: comments in commandViews,
levelDropdownView, multiView, visuals
All tests passing (206/206 specs)
✅ Deploy Preview for xenodochial-hugle-b9ec84 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
|
Thanks a ton @ArtemioPadilla ! tons of great fixes in here and a bunch of new es_MX translations for the levels. I really appreciate the contribution 🙌🏻 |
Owner
|
Oh wow sorry @ArtemioPadilla that I never merged this, seems like maybe it got stale? Do you want to try to rebase the diff or should I? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errors
Files affected:
All tests passing (206/206 specs)