Add support for K8S Ingress Header X-Original-Forwarded-For#88
Open
Ismaaa wants to merge 1 commit intopbojinov:masterfrom
Open
Add support for K8S Ingress Header X-Original-Forwarded-For#88Ismaaa wants to merge 1 commit intopbojinov:masterfrom
Ismaaa wants to merge 1 commit intopbojinov:masterfrom
Conversation
|
Is this library sill maintained? |
|
Nice, but shouldn't it be before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there! I've added support for the
X-Original-Forwarded-Forheader, which is used by Kubernetes Ingress.I've also put together a few tests to make sure everything works as expected:
I believe these changes will make IP resolution in Kubernetes Ingress environments even better. Please have a look and let me know what you think.