fix(ui): make linked table cells fully clickable in drawers#17036
Open
PatrikKozak wants to merge 2 commits into
Open
fix(ui): make linked table cells fully clickable in drawers#17036PatrikKozak wants to merge 2 commits into
PatrikKozak wants to merge 2 commits into
Conversation
PatrikKozak
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
JarrodMFlesch
requested changes
Jun 17, 2026
JarrodMFlesch
left a comment
JarrodMFlesch
left a comment
Contributor
There was a problem hiding this comment.
This seems to have broken versions drawer table padding.
You can see it by going to versions -> compare against -> more versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the linked cell in drawer-rendered tables fill the entire
<td>, matching the list view where the whole cell is clickable rather than just the text.In drawer tables the linked column is the first cell, since drawers have no row-select checkbox column. The
td:first-childpadding rules - in particular the drawer variant.drawer .table td:first-child(specificity(0,3,1)) - overrode.cell--linked { padding: 0 }(specificity(0,2,0)), leaving padding on the<td>that the inner element did not cover. Drawer linked cells also render a<button>(with anonSelecthandler) instead of an<a>, and a button withwidth: autoonly sizes to its text, so only the text was clickable.The fix scopes the linked-cell rules to
td.cell--linkedwith explicit:first-child/:last-childpadding resets so they win over the cell padding rules, addswidth: 100%to the inner<a>/<button>so buttons stretch like anchors, and moves the first-cell gutter onto the inner element so text alignment is unchanged.Before:
The drawer linked cell renders a
<button>sized to its text — only the text is clickable.After:
The
<button>fills the full cell (width and height) withcursor: pointer, matching the list view<a>behavior.