FISH-12828 create node version command#7944
Open
NotedSalmon wants to merge 1 commit intopayara:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FISH-12828 Implement remote node version feature
Description
Created a new
ListNodeVersionCommand+ Helper. It gets the list of nodes and checks theinstallDirfor each one. Checks theglassfish-version.propertiesand builds a version using the major, minor and update version.The command then tries to find for a
config.oldorconfig.newfolder which would be created if an upgrade was staged.If the node is remote, it will first download the properties file into a temporary directory and then read it. It would then safely delete the directory after it has been used.
The command outputs a table similarly to how
list-nodes --longcommand does, showing each nodes version.Important Info
Testing
Testing Performed
Created 3 nodes,
local with 7.0.0,SSH with 7.0.0andSSH with 6.3.3Ran
list-node-versionswhich will display each version of each node."Upgraded"
LocalandSSH with 6.3.3to version7.1.0(I just changed the version to 7.1.0 to test the upgrade) with stage.Another way is, just copy + paste config folders and rename to .new/.old and change the
glassfish-version.propertiesversions manuallyDocumentation
Notes for Reviewers