Add analytics tracking code with documentation.#441
Add analytics tracking code with documentation.#441rebeccaalpert merged 5 commits intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-441.surge.sh A11y report: https://chatbot-pr-chatbot-441-a11y.surge.sh |
Heiko has a PR adding analytics documentation. This does not work if we try to pre-render the ChatBot with the docs framework, but works fine normally. This seems to fix the issue locally in node_modules. Here's the corresponding PR: patternfly/chatbot#441
Heiko has a PR adding analytics documentation. This does not work if we try to pre-render the ChatBot with the docs framework, but works fine normally. This seems to fix the issue locally in node_modules. Here's the corresponding PR: patternfly/chatbot#441
|
We need to merge patternfly/patternfly-org#4467, update the docs framework in a bunch of places, and then hopefully update chatbot to fix this build error. |
Heiko has a PR adding analytics documentation. This does not work if we try to pre-render the ChatBot with the docs framework, but works fine normally. This seems to fix the issue locally in node_modules. Here's the corresponding PR: patternfly/chatbot#441
|
@pilhuhn As I was reviewing the content here, I had a lot of feedback and felt like it would be easier to open a separate pr against yours: pilhuhn#3. We can sort out things over there and merge it in when it's ready? I made updates to content, but also recreated your images with styling that's more similar to other images on the website. Let me know if anything is incorrect or can be further updated! Also cc @rebeccaalpert to make sure everything over there looks okay |
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
Looks great to me! Thank you.
|
Thank you @edonehoo for your copy-editing |
|
🎉 This PR is included in version 2.2.0-prerelease.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
This is basically the same as #339, but my code changes applied to a fresh checkout from main.
Closes #339 as obsolete.