Skip to content

No longer catching all errors during term compatibility checks #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrick-kidger merged 1 commit into from
Aug 31, 2025
Merged

No longer catching all errors during term compatibility checks #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions diffrax/_integrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,7 @@ def _check(term_cls, term, term_contr_kwargs, yi):
pass
elif n_term_args == 2:
vf_type_expected, control_type_expected = term_args
try:
vf_type = eqx.filter_eval_shape(term.vf, t, yi, args)
except Exception as e:
raise ValueError(f"Error while tracing {term}.vf: " + str(e))
vf_type = eqx.filter_eval_shape(term.vf, t, yi, args)
vf_type_compatible = eqx.filter_eval_shape(
better_isinstance, vf_type, vf_type_expected
)
Expand All @@ -173,10 +170,7 @@ def _check(term_cls, term, term_contr_kwargs, yi):

contr = ft.partial(term.contr, **term_contr_kwargs)
# Work around https://github.com/google/jax/issues/21825
try:
control_type = eqx.filter_eval_shape(contr, t, t)
except Exception as e:
raise ValueError(f"Error while tracing {term}.contr: " + str(e))
control_type = eqx.filter_eval_shape(contr, t, t)
control_type_compatible = eqx.filter_eval_shape(
better_isinstance, control_type, control_type_expected
)
Expand Down
Loading