Skip to content

Fix dtype comparison using 'is' instead of '==' in _integrate.py #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrick-kidger merged 1 commit into from
Aug 15, 2025
Merged

Fix dtype comparison using 'is' instead of '==' in _integrate.py #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions diffrax/_integrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def _clip_to_end(tprev, tnext, t1, keep_step):
# The tolerance means that we don't end up with too-small intervals for
# dense output, which then gives numerically unstable answers due to floating
# point errors.
if tnext.dtype is jnp.dtype("float64"):
if tnext.dtype == jnp.dtype("float64"):
tol = 1e-10
else:
tol = 1e-6
Expand Down Expand Up @@ -385,7 +385,7 @@ def body_fun_aux(state):
error_order,
state.controller_state,
)
assert jnp.result_type(keep_step) is jnp.dtype(bool)
assert jnp.result_type(keep_step) == jnp.dtype(bool)

#
# Do some book-keeping.
Expand Down
Loading