Fix connector issues when loading zip files#235
Merged
dbrakenhoff merged 5 commits intodevfrom Apr 29, 2026
Merged
Conversation
Member
dbrakenhoff
commented
Apr 29, 2026
dbrakenhoff
commented
- DictConnector was failing because it "remembered" _added_model lists from older instances because I defined a mutable attribute at the class level instead of in init.
- PasConnector was failing because it did not realize the zip unpacking had placed data in its folders. Now a resync is forced so it is aware of all the data that was unzipped.
change class attributes to immutable types
OnnoEbbens
approved these changes
Apr 29, 2026
Member
OnnoEbbens
left a comment
OnnoEbbens
left a comment
There was a problem hiding this comment.
Thanks for solving this so fast!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.