Skip to content

fix: Incorrect dependency chain of Parse uses browser build instead of Node build#10067

Merged
mtrezza merged 2 commits intoparse-community:alphafrom
mtrezza:fix/parse-import
Feb 21, 2026
Merged

fix: Incorrect dependency chain of Parse uses browser build instead of Node build#10067
mtrezza merged 2 commits intoparse-community:alphafrom
mtrezza:fix/parse-import

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Feb 21, 2026

Pull Request

Issue

Incorrect dependency chain of Parse uses browser build instead of Node build. This causes all kinds of difficult to debug bugs because Parse builds for browser and Node are imported, may or not be initialized and overwrite each other due to a globally pinned Parse object. The fundamental fix will be #8787 in the future. This PR fixed an immediate issue that causes CI fails and can cause production code issues. Part of the fix is the update to @parse/push-adapter 8.3.1 which also imports the browser build of Parse instead of the Node build. This and the import in Parse Server's FilesController produce this strange interaction.

Summary by CodeRabbit

  • Chores
    • Updated internal module dependencies to improve code maintainability.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 21, 2026

🚀 Thanks for opening this pull request!

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Feb 21, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link

coderabbitai bot commented Feb 21, 2026

📝 Walkthrough

Walkthrough

Swaps the Parse SDK import in src/Controllers/FilesController.js to use the parse/node entry point and bumps the @parse/push-adapter dependency version in package.json. No other code or exported API signatures were changed.

Changes

Cohort / File(s) Summary
Parse Import Path Update
src/Controllers/FilesController.js
Changed Parse import source from the root parse package to the parse/node entry point; usage (e.g., Parse.Error) unchanged.
Dependency Bump
package.json
Updated @parse/push-adapter dependency from 8.3.0 to 8.3.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: fixing an incorrect Parse import that was using the browser build instead of Node build in FilesController.
Description check ✅ Passed The PR description includes the issue, approach, and context, but lacks the Tasks section required by the template.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 21, 2026
@mtrezza mtrezza changed the title fix: Incorrect Parse import in FilesController fix: Incorrect Parse import in FilesController uses browser build instead of Node build Feb 21, 2026
@mtrezza mtrezza changed the title fix: Incorrect Parse import in FilesController uses browser build instead of Node build fix: Incorrect dependency chain of Parse uses browser build instead of Node build Feb 21, 2026
@mtrezza mtrezza merged commit 1a2521d into parse-community:alpha Feb 21, 2026
20 of 21 checks passed
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.57%. Comparing base (8b5a14e) to head (ff6fc11).
⚠️ Report is 5 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha   #10067      +/-   ##
==========================================
+ Coverage   92.16%   92.57%   +0.41%     
==========================================
  Files         191      191              
  Lines       15603    15603              
  Branches      176      176              
==========================================
+ Hits        14380    14445      +65     
+ Misses       1207     1146      -61     
+ Partials       16       12       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

parseplatformorg pushed a commit that referenced this pull request Feb 21, 2026
# [9.3.0-alpha.8](9.3.0-alpha.7...9.3.0-alpha.8) (2026-02-21)

### Bug Fixes

* Incorrect dependency chain of `Parse` uses browser build instead of Node build ([#10067](#10067)) ([1a2521d](1a2521d))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 9.3.0-alpha.8

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 21, 2026
@mtrezza mtrezza deleted the fix/parse-import branch February 21, 2026 02:02
parseplatformorg pushed a commit that referenced this pull request Feb 21, 2026
# [9.3.0](9.2.0...9.3.0) (2026-02-21)

### Bug Fixes

* `Parse.Query.select('authData')` for `_User` class doesn't return auth data ([#10055](#10055)) ([44a5bb1](44a5bb1))
* AuthData validation incorrectly triggered on unchanged providers ([#10025](#10025)) ([d3d6e9e](d3d6e9e))
* Default ACL overwrites custom ACL on `Parse.Object` update ([#10061](#10061)) ([4ef89d9](4ef89d9))
* Default HTML pages for password reset, email verification not found ([#10034](#10034)) ([e299107](e299107))
* Default HTML pages for password reset, email verification not found ([#10041](#10041)) ([a4265bb](a4265bb))
* Incorrect dependency chain of `Parse` uses browser build instead of Node build ([#10067](#10067)) ([1a2521d](1a2521d))
* Unlinking auth provider triggers auth data validation ([#10045](#10045)) ([b6b6327](b6b6327))

### Features

* Add `Parse.File.url` validation with config `fileUpload.allowedFileUrlDomains` against SSRF attacks ([#10044](#10044)) ([4c9c948](4c9c948))
* Add event information to `verifyUserEmails`, `preventLoginWithUnverifiedEmail` to identify invoking signup / login action and auth provider ([#9963](#9963)) ([ed98c15](ed98c15))
* Add support for streaming file upload via `Buffer`, `Readable`, `ReadableStream` ([#10065](#10065)) ([f0feb48](f0feb48))
* Upgrade to parse 8.2.0, @parse/push-adapter 8.3.0 ([#10066](#10066)) ([8b5a14e](8b5a14e))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 9.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants