Skip to content

feat: Allow large uploads via Blob - #598

Open
AdrianCurtin wants to merge 1 commit into
parse-community:masterfrom
AdrianCurtin:feat-blob-upload
Open

feat: Allow large uploads via Blob#598
AdrianCurtin wants to merge 1 commit into
parse-community:masterfrom
AdrianCurtin:feat-blob-upload

Conversation

@AdrianCurtin

Copy link
Copy Markdown

Issue

Closes: #228

A Blob handed to createFile has no pipe, so it misses the streaming path added in #459 and is passed to PutObjectCommand whole. That materializes the entire file in memory, which is exactly what fails for uploads past the V8 buffer limit, the case #228 is about.

Picks up #229 by @dalyaidan1, which implemented this against the v2 SDK. @vahidalizad asked there for it to be redone on v3 after #221 landed, and it was never revisited. This is that rewrite, and it is much smaller now, because #459 already added the multipart upload path that the blob only needs routing into.

Approach

Anything exposing a web stream, a Blob or a File, is converted to a Readable before the params are built, so the existing Upload path carries it:

if (data && typeof data.stream === 'function' && typeof data.pipe !== 'function') {
  data = Readable.fromWeb(data.stream());
}

Duck typed on stream() rather than instanceof Blob, so a File, a blob from another realm, or a polyfill all work. The pipe check keeps a Node Readable on its existing path untouched.

The original PR built its own PassThrough and piped into it. That is no longer needed: Upload accepts a Readable directly and handles the multipart chunking, so this adds no plumbing of its own.

Behavior

  • A Blob now streams to S3 in parts instead of being buffered, so memory use is bounded by the part size rather than by the file size.
  • Buffer and string bodies are unchanged and still use PutObjectCommand.
  • Node Readable bodies are unchanged.

Tests

spec/test.spec.js gains a blob uploads block: a blob takes the multipart path rather than PutObjectCommand, the upload is handed a Readable rather than the blob, the contents survive the conversion, and the source is not drained by the conversion itself, which is the property that makes an oversized file possible at all.

All four fail against the current implementation. Full suite passes.

@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@AdrianCurtin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a8ae2911-8ea3-4523-aa90-1cec633c3a23

📥 Commits

Reviewing files that changed from the base of the PR and between b9245cb and dfc0558.

📒 Files selected for processing (2)
  • index.js
  • spec/test.spec.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse.Files cannot be created if over 512MB

1 participant