Gate zombienet-sdk behind cfg(unix) to fix Windows builds#254
Merged
Conversation
Temporarily adding this fix here until verified that CI is fixed in revive compiler with this. The 'retester' binary depends on 'revive-dt-node', which depends on 'zombienet-sdk'. The 'zombienet-support' crate uses 'std::os::unix' unconditionally.
0xOmarA
reviewed
Mar 16, 2026
0xOmarA
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
retesterbinary depends onrevive-dt-node, which depends onzombienet-sdk. Thezombienet-supportcrate usesstd::os::unix, which fails to compile on Windows. Since zombienet only runs on unix systems, this PR cfg-gates thezombienet-sdkdependency and all zombienet-related code behind#[cfg(unix)].The revive compiler repo needs to run compilation-only for Windows builds as well. See e.g. this failed run.
Alternatives
Feature-gating the entire
revive-dt-nodecrate behind e.g. anodesfeature would allow a lightweight compile-only build, but is a bit more invasive than the above approach (and would probably still be good to combine with the above approach in order to make compilations on Windows just work out of the gate).