perf(engine): reduce write lock hold time in save_cache#23350
Open
AKABABA-ETH wants to merge 1 commit intoparadigmxyz:mainfrom
Open
perf(engine): reduce write lock hold time in save_cache#23350AKABABA-ETH wants to merge 1 commit intoparadigmxyz:mainfrom
AKABABA-ETH wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
Moved expensive operations (`insert_state`, `update_metrics`, `recv`) outside the write lock in `save_cache()`. The lock is now only held for the final quick assignment, reducing block time from tens of milliseconds to microseconds.
AKABABA-ETH
requested review from
Rjected,
mattsse and
mediocregopher
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved expensive operations (
insert_state,update_metrics,recv) outside the write lock insave_cache(). The lock is now only held for the final quick assignment, reducing block time from tens of milliseconds to microseconds.