BUG: distinguish bool from int in object-dtype hash table#64639
Open
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Open
BUG: distinguish bool from int in object-dtype hash table#64639jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Conversation
…#62888) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyobject_cmp()(khash_python.h), added a type guard that returns not-equal when exactly one of the two objects is a Pythonbool(PyBool_Check). This correctly distinguishesint(0)frombool(False)andint(1)frombool(True)in the khash equality function used byPyObjectHashTable.factorize,unique,duplicated,isin,value_counts,groupby, andIndex.get_locfor object-dtype data containing mixed bool/int values.PyBool_Check(reads the type pointer) on each side, executed only when types already differ.Test plan
test_algos.pyforfactorize,unique,isin,value_counts,duplicatedtest_indexing.pyforget_indexer,get_loc,is_uniquetest_groupby.pyfor groupby with mixed bool/int keys🤖 Generated with Claude Code