CLN: Enable ruff rule PLR1730 (if-stmt-min-max)#64130
Open
Moisan wants to merge 1 commit intopandas-dev:mainfrom
Open
CLN: Enable ruff rule PLR1730 (if-stmt-min-max)#64130Moisan wants to merge 1 commit intopandas-dev:mainfrom
Moisan wants to merge 1 commit intopandas-dev:mainfrom
Conversation
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
To be honest, I am not sure I find this more readable or easier to understand ...
| if is_max: | ||
| if val > output[lab]: | ||
| output[lab] = val | ||
| output[lab] = max(output[lab], val) |
Member
There was a problem hiding this comment.
This is not actually equivalent? Because in the new code, the setitem operation always happens, while in the existing code only if needed (that can have a performance difference?)
rhshadrach
requested changes
Feb 13, 2026
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
This linting rule is under intentionally disabled in pyproject.toml. If you think that is a wrong decision, open an issue for discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.