Skip to content

Control Variables in PALS#178

Open
qianglbl wants to merge 36 commits intopals-project:mainfrom
qianglbl:alsinjector
Open

Control Variables in PALS#178
qianglbl wants to merge 36 commits intopals-project:mainfrom
qianglbl:alsinjector

Conversation

@qianglbl
Copy link
Copy Markdown
Contributor

@qianglbl qianglbl commented Feb 11, 2026

In a real machine like the ALS injector,
there is a middle layer that contains control variables for the EPICS system.

Where should these variables be placed within PALS?

qianglbl and others added 27 commits November 14, 2025 17:21
@qianglbl
modified three files
ff8dec3
@qianglbl
modified 3 parameter files.
0fbf840
@qianglbl
updated beambeam.md and element-kinds.md
efc8715
@qianglbl
added description of elements in the element-kinds.md
fb79813
@qianglbl
remove the edit
073a64f
@qianglbl
modified description of Instrument, Kicker, and RFCavity in
a2abadf 
element-kinds.
@qianglbl
updated default values
3bc7ab5
@qianglbl @cemitch99
Update source/element-kinds.md
4f48acd 
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>
@qianglbl
modified the description of RFCavity element
dc9d463
@qianglbl
modied defaults ...
93382d2
@qianglbl
added other moments
da9f34e
@qianglbl
made a few minor changes
370c63a
@qianglbl @cemitch99
Update source/element-kinds.md
9d2274b 
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>
@qianglbl
removed RMS size
eba1164
@qianglbl @cemitch99
Update source/parameters/initialparticle.md
9e9cd56 
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>
@qianglbl
changed mu into sigma
f1055b6
@qianglbl
fixed one element
f4ea605
@qianglbl
put back zero length...
88c0962
@qianglbl
modified ACkicker
8e08167
@qianglbl
updated
2cf6eeb
@qianglbl
fixed
cf3205a
@qianglbl
removed the default values
c6b8c7f
@qianglbl
slight changes
3833579
@qianglbl
small update
59c5abd
@qianglbl
Merge branch 'main' into addtemp
2a28977
@qianglbl
added an ALS injector prototype
705ae79
@qianglbl
Merge branch 'main' into alsinjector
c284d93
@qianglbl qianglbl requested a review from cemitch99 February 11, 2026 22:59
@DavidSagan
Copy link
Copy Markdown
Member

DavidSagan commented Feb 16, 2026

This is missing PALS root node and lattice constructs.

@cemitch99 cemitch99 requested review from DavidSagan, EZoni and jlvay March 2, 2026 18:46
@cemitch99
Copy link
Copy Markdown
Contributor

cemitch99 commented Mar 2, 2026 •
edited
Loading

Discussed: Remove length = 0 for Marker elements. Add default values for a few blank entry fields.

@DavidSagan
Copy link
Copy Markdown
Member

DavidSagan commented Mar 2, 2026

Needs header:

PALS:
  facility:

cemitch99
cemitch99 reviewed Mar 2, 2026
View reviewed changes
Comment thread examples/alsinj.pals.yaml Outdated

- START:
kind: Marker
length: 0.0
Copy link
Copy Markdown
Contributor

@cemitch99 cemitch99 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
length: 0.0

Copy link
Copy Markdown
Contributor Author

@qianglbl qianglbl Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove "length" line

cemitch99
cemitch99 reviewed Mar 2, 2026
View reviewed changes
Comment thread examples/alsinj.pals.yaml Outdated
cemitch99
cemitch99 reviewed Mar 2, 2026
View reviewed changes
Comment thread examples/alsinj.pals.yaml Outdated
cemitch99
cemitch99 reviewed Mar 2, 2026
View reviewed changes
Comment thread examples/alsinj.pals.yaml Outdated

- END:
kind: Marker
length: 0.0
Copy link
Copy Markdown
Contributor

@cemitch99 cemitch99 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
length: 0.0

Copy link
Copy Markdown
Contributor Author

@qianglbl qianglbl Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "length" line

cemitch99
cemitch99 reviewed Mar 2, 2026
View reviewed changes
Comment thread examples/alsinj.pals.yaml Outdated
cemitch99
cemitch99 reviewed Mar 2, 2026
View reviewed changes
Comment thread examples/alsinj.pals.yaml Outdated
cemitch99
cemitch99 reviewed Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @qianglbl . I made some suggestions based on the discussion today.

qianglbl and others added 4 commits March 2, 2026 13:49
@qianglbl @cemitch99
Apply suggestion from @cemitch99
8e1e6f1 
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>
@qianglbl @cemitch99
Apply suggestion from @cemitch99
90040e0 
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>
@qianglbl @cemitch99
Apply suggestion from @cemitch99
be9e668 
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>
@qianglbl @cemitch99
Apply suggestion from @cemitch99
cad0a3b 
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>
qianglbl
qianglbl commented Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@qianglbl qianglbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "length" line for START and END

@qianglbl
Copy link
Copy Markdown
Contributor Author

qianglbl commented Mar 4, 2026

@DavidSagan PALS header added. Also, I don't understand why we should remove "length : 0.0" for the START and END elements?

@qianglbl
Copy link
Copy Markdown
Contributor Author

qianglbl commented Mar 6, 2026

@DavidSagan The two length lines for START and END elements were removed.

@DavidSagan
Copy link
Copy Markdown
Member

DavidSagan commented Mar 10, 2026

@qianglbl It is looking good. The only thing missing now is a Lattice construct:

- ALS_Injector
    kind: Lattice
    branches:
      - LTB

@qianglbl
Copy link
Copy Markdown
Contributor Author

qianglbl commented Mar 13, 2026

@DavidSagan Thanks and added the Lattice construct.

@EZoni
Copy link
Copy Markdown
Member

EZoni commented Apr 13, 2026 •
edited
Loading

@qianglbl

Do we want to include control variable information in this PR? If not, what does this example alone, as is, describe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidSagan DavidSagan DavidSagan approved these changes

@cemitch99 cemitch99 cemitch99 approved these changes

@jlvay jlvay Awaiting requested review from jlvay

@EZoni EZoni Awaiting requested review from EZoni

Assignees

No one assigned

Labels

discussion (do not merge) examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qianglbl @DavidSagan @cemitch99 @EZoni @ax3l