This repository was archived by the owner on Jul 30, 2024. It is now read-only.
Enable token authentication for change_password()#785
Open
jirikuncar wants to merge 3 commits intopallets-eco:developfrom
Open
Enable token authentication for change_password()#785jirikuncar wants to merge 3 commits intopallets-eco:developfrom
jirikuncar wants to merge 3 commits intopallets-eco:developfrom
Conversation
Previously, only @login_required was used, therefore token authentication could not be used to change the user password.
This enables updating saved token upon changing password without having to (log out and) log in again in order to get new auth token.
Allow token authentication for the change_password endpoint. This makes it possible change passwords from a json request. Related-to: pallets-eco#421 Signed-off-by: David Aguilar <[email protected]>
Collaborator
|
A couple subtle behavior changes that this exposes - possibly we should address those as well. @login_required has some additional features: This change alters those 2. My feeling is that it would be better to simply teach auth_required() to support the OPTIONS feature - not sure LOGIN_DISABLED is important? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
closes #479