This repository was archived by the owner on Jul 30, 2024. It is now read-only.
check that user model has roles attr on user create#739
Open
Jaza wants to merge 2 commits intopallets-eco:developfrom
Open
check that user model has roles attr on user create#739Jaza wants to merge 2 commits intopallets-eco:developfrom
Jaza wants to merge 2 commits intopallets-eco:developfrom
Conversation
jirikuncar
suggested changes
Jan 7, 2018
Contributor
jirikuncar
left a comment
jirikuncar
left a comment
There was a problem hiding this comment.
Please add new tests. Thanks!
flask_security/datastore.py
Outdated
Contributor
There was a problem hiding this comment.
I would rather see an exception if you try to save user with roles.
if not hasattr(self.user_model, 'roles') and kwargs.get('roles'):
raise # custom Flask-Security exception
Contributor
Author
There was a problem hiding this comment.
Ok @jirikuncar, now raising an exception as you suggested, and have added tests.
Sorry it took me a whole year to respond to your feedback. Anyway, better late than never!
Jaza
force-pushed
the
check-roles-on-user-create
branch
from
55a5653 to
810e365
Compare
Collaborator
|
If you are doing all this checking - would it make sense to exception if role doesn't exist - rather than just ignoring it? That would seem like a equally bad 'admin/config' error... |
jasco
pushed a commit
to jasco/flask-security
that referenced
this pull request
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.