specify coding style for Walmart#1658
Open
kshao56 wants to merge 2 commits intopalantir:developfrom
Open
Conversation
Member
|
Thanks for your interest in palantir/palantir-java-format, @kshao56! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
Author
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
The palantir-java-format library supports three coding styles: PALANTIR (2-space indent, 120 char line length), GOOGLE (1-space indent multiplier, 100 char line length), and AOSP (2-space indent, 100 char line length). There was no option for teams that prefer Google-style import ordering with a 120 character line length limit.
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Add WALMART style option that combines Google-style formatting (1-space indent multiplier, Google import ordering) with a 120 character maximum line length. This provides an alternative for teams who prefer the readability of longer lines while maintaining Google's import organization conventions.
Possible downsides?