Skip to content

fix(core): Preserve minimal=false in Popover migration props - #8216

Merged
ggdouglas merged 2 commits into
developfrom
gd/fix-popover-minimal-false-conversion
Jul 28, 2026
Merged

fix(core): Preserve minimal=false in Popover migration props#8216
ggdouglas merged 2 commits into
developfrom
gd/fix-popover-minimal-false-conversion

Conversation

@ggdouglas

Copy link
Copy Markdown
Contributor

Summary

popoverPropsToNextProps currently translates minimal: true but drops an explicit minimal: false. This prevents converted props from restoring the standard arrow and scale animation when spread over a wrapper component’s defaults.

Changes

  • Map minimal: false to arrow: true and animation: "scale".
  • Add regression coverage for direct conversion and wrapper prop overrides.

@changelog-app

changelog-app Bot commented Jul 21, 2026

Copy link
Copy Markdown

Generate changelog in packages/core/changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

fix(core): Preserve minimal=false in Popover migration props

Check the box to generate changelog(s)

  • Generate changelog entry

@changelog-app

changelog-app Bot commented Jul 21, 2026

Copy link
Copy Markdown

Successfully generated changelog entry!

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.


📋Changelog Preview

🐛 Fixes

  • fix(core): Preserve minimal=false in Popover migration props (#8216)

@ggdouglas ggdouglas changed the title fix(core): Preserve minimal=false in Popover migration props fix(core): Preserve minimal=false in Popover migration props Jul 21, 2026
@blueprint-previews

Copy link
Copy Markdown

Fix Popover minimal false conversion

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

Comment thread packages/core/src/components/popover-next/popoverNextMigrationUtils.ts Outdated
Comment thread packages/core/src/components/popover-next/popoverNextMigrationUtils.test.ts Outdated
@ggdouglas
ggdouglas requested a review from andyboscor July 28, 2026 15:44
@blueprint-previews

Copy link
Copy Markdown

Address review: null-safe minimal guard, shared PopoverNext defaults

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas
ggdouglas merged commit e1c9bb7 into develop Jul 28, 2026
15 checks passed
@ggdouglas
ggdouglas deleted the gd/fix-popover-minimal-false-conversion branch July 28, 2026 16:22
@autorelease3

autorelease3 Bot commented Jul 28, 2026

Copy link
Copy Markdown

Released as part of @blueprintjs/core@6.18.0

This creates a tag and GitHub release. Additional build or deployment steps may still be in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants