tests: more cases for qualifier spec#738
tests: more cases for qualifier spec#738jkowalleck wants to merge 3 commits intopackage-url:mainfrom
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
johnmhoran
left a comment
There was a problem hiding this comment.
@jkowalleck The build and parse tests look accurate to me -- nice level of detail, too. 👍 My understanding is that we will not be using the roundtrip test_type, so those tests will need to be deleted.
why is this? I mean, the roundtrip exists for a very good reason: test canonicalization of string input. |
|
@jkowalleck We have been trying to figure out the use case for roundtrip - no decision has been made. Philippe described roundtrip as a shortcut for combining a set of parse and build tests. Could you explain more about the use case for roundtrip? Is it somehow equivalent to "validation" of a string input? |
I used it as "i get some PURL string input, and want to re-usue it with all normalizations and cleaning applied." |
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
caused by https://github.com/package-url/purl-spec/pull/730/files#r2493378205 and others