Skip to content

Update protobuf to 29.6 and remove abseil GCC >14 workarounds#5550

Merged
fruffy merged 2 commits intofruffy/abslfrom
copilot/sub-pr-5491
Mar 19, 2026
Merged

Update protobuf to 29.6 and remove abseil GCC >14 workarounds#5550
fruffy merged 2 commits intofruffy/abslfrom
copilot/sub-pr-5491

Conversation

Copy link
Contributor

Copilot AI commented Mar 19, 2026

Protobuf 25.3 breaks when built against abseil 20260107.1: utf8_validity.cc relied on memcpy being pulled in transitively through absl/strings/ascii.h, which the new abseil no longer provides.

Changes

  • cmake/Protobuf.cmake: Bump protobuf 25.329.6. The rewritten utf8_validity.cc in 29.x no longer has the transitive <cstring> dependency.
  • cmake/Abseil.cmake: Remove the -mbmi compiler flag workaround for GCC >14 (tracked as abseil-cpp#1664) and its associated warning — fixed in abseil 20260107.1.

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: fruffy <5960321+fruffy@users.noreply.github.com>
Copilot AI changed the title [WIP] Update abseil version and remove TODO workarounds Update protobuf to 29.6 and remove abseil GCC >14 workarounds Mar 19, 2026
Copilot AI requested a review from fruffy March 19, 2026 02:17
@fruffy fruffy marked this pull request as ready for review March 19, 2026 02:26
@fruffy fruffy merged commit 341fd36 into fruffy/absl Mar 19, 2026
3 checks passed
@fruffy fruffy deleted the copilot/sub-pr-5491 branch March 19, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants