Open
Conversation
Signed-off-by: Chris Dodd <[email protected]>
Collaborator
|
Test for this would be nice. This way we can make sure other tools can be tested on these syntax details. |
fruffy
added
the
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it was parsing
+:as two tokens, that caused the effective precedence to be that of+. So if you tried to something likesomevar[val & 0x3f +: 1]
to mask a value and get the corresponding bit, it would give a syntax error on the
:. Problem could be worked around by adding parens, but they should not be necessary.This change also requires the
+:be together (no space between them), which is not stated explicitly in the spec, but is implied that it is a single token, like other multichar tokens.