Add option to keep selection when clearing search#1371
Open
Ahelsamahy wants to merge 1 commit intop0deje:masterfrom
Open
Add option to keep selection when clearing search#1371Ahelsamahy wants to merge 1 commit intop0deje:masterfrom
Ahelsamahy wants to merge 1 commit intop0deje:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add option to keep selection when clearing search
Today, when search is cleared, Maccy always jumps selection back to the first unpinned item.
With this change, users can enable a setting to keep the previously selected item instead.
Problem
My common workflow is:
Current behavior resets selection to the top.
Changes
preserveSelectionAfterSearch(default:false)History.searchQuery.didSet:HistoryTestsfor:Backward compatibility
false, so existing behavior is unchanged unless users enable it.Testing
xcodebuild build -project Maccy.xcodeproj -scheme Maccy -configuration Release -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NOHistoryTestsfor new behavior.I couldn't find a way to know how to run the changes locally. I came up with these
Notes