Avoid orphaned HistoryItemContent rows during duplicate handling#1369
Open
fitchmultz wants to merge 2 commits intop0deje:masterfrom
Open
Avoid orphaned HistoryItemContent rows during duplicate handling#1369fitchmultz wants to merge 2 commits intop0deje:masterfrom
fitchmultz wants to merge 2 commits intop0deje:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1368
Summary
History.add(_:)Details
The original change fixed the unsaved duplicate path, but it also introduced a broader cleanup migration that went beyond the narrow bugfix.
This version keeps the smallest direct fix and also covers the directly attached saved-duplicate case that surfaced while adding regression tests. In both cases, duplicate collapse should leave one history item and no orphaned
HistoryItemContentrows.Testing