Add Hex Color Swatch Show Setting in Preferences#1338
Add Hex Color Swatch Show Setting in Preferences#1338umang350 wants to merge 3 commits intop0deje:masterfrom
Conversation
weisJ
left a comment
There was a problem hiding this comment.
Is the color swatch showing really that bothering you? (I don't have nothing against this change)
It would be great if you could provide real translations instead of just stubbing them out.
| .frame(width: showIcons ? 5 : 10) | ||
|
|
||
| if let accessoryImage { | ||
| if showHexColorSwatch, let accessoryImage { |
There was a problem hiding this comment.
This is not the correct place for this check. You need to pass nil to accessoryImage in HistoryItemView. In the future there might be other accessory images for different reasons.
There was a problem hiding this comment.
Moved the logic to correct location.
Color swatch seems to be annoying when I am not dealing with HEX codes but just bare numbers. Just OCD and not able to figure out what the square box was until i read the source code to figure it out. I don't code everyday, just a PM. |
Summary
Implementation
Files changed
Test plan