Fix unhandled exception when accessing machine fields (fixes #920)#939
Merged
ankushdesai merged 1 commit intomasterfrom Mar 11, 2026
Merged
Fix unhandled exception when accessing machine fields (fixes #920)#939ankushdesai merged 1 commit intomasterfrom
ankushdesai merged 1 commit intomasterfrom
Conversation
The P compiler was throwing an ArgumentOutOfRangeException when code attempted to access fields of a machine reference (e.g., server.database). This change restricts machine field access to PVerifier contexts only (proof blocks), producing a proper type error in regular P code. Changes: - Add isPVerifier flag to ExprVisitor to control machine field access - Guard PermissionType and PrimitiveType.Machine field access with isPVerifier - Enable isPVerifier in Analyzer.cs and ProofBlockVisitor.cs - Conditionally enable in StatementVisitor based on PVerifier output mode Test cases added: - MachineFieldAccess: Direct machine field access - MachineFieldAccessNested: Chained machine field access - MachineFieldAccessInExpr: Machine field in arithmetic expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The P compiler was throwing an ArgumentOutOfRangeException when code attempted to access fields of a machine reference (e.g., server.database). This change restricts machine field access to PVerifier contexts only (proof blocks), producing a proper type error in regular P code.
Changes:
Test cases added: