[test-utils] fix wait_for_watch_channel_condition#10569
Merged
sunshowers merged 3 commits intoJun 10, 2026
Merged
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Contributor
Author
|
(Went with a slightly more aggressive refactor than I did originally -- I think it's worth it but I can go back to the earlier version if you feel strongly about it) |
jgallagher
approved these changes
Jun 8, 2026
Contributor
Author
|
lol, this ran into #10567. incredible |
2 tasks
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/test-utils-fix-wait_for_watch_channel_condition
branch
hawkw
pushed a commit
that referenced
this pull request
Jun 10, 2026
Rewrite to be much simpler -- we don't need the existing genericity in practice, and it's easier to just rely on `rx.wait_for`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite to be much simpler -- we don't need the existing genericity in practice, and it's easier to just rely on
rx.wait_for.