Skip to content

[bgp-config] add networking_bgp_config_update endpoint#10566

Open
nicolaskagami wants to merge 5 commits into
mainfrom
nsk/bgp-config-update-endpoint
Open

[bgp-config] add networking_bgp_config_update endpoint#10566
nicolaskagami wants to merge 5 commits into
mainfrom
nsk/bgp-config-update-endpoint

Conversation

@nicolaskagami

@nicolaskagami nicolaskagami commented Jun 8, 2026

Copy link
Copy Markdown

Adds a networking_bgp_config_update endpoint with the following updatable fields:

pub struct BgpConfigUpdate {
    #[serde(flatten)]
    pub identity: IdentityMetadataUpdateParams,

    /// Update the BGP announce set associated with this configuration.
    pub bgp_announce_set_id: Option<NameOrId>,

    /// Update the maximum number of equal-cost paths.
    pub max_paths: Option<MaxPathConfig>,
}
  • vrf isn't added because it's to be removed.
  • asn isn't included because it may be used as an id internally.

closes #10066

@nicolaskagami nicolaskagami self-assigned this Jun 8, 2026
@nicolaskagami nicolaskagami force-pushed the nsk/bgp-config-update-endpoint branch from 73050fb to 9ca6ecf Compare June 10, 2026 13:16
@nicolaskagami nicolaskagami force-pushed the nsk/bgp-config-update-endpoint branch from 9ca6ecf to b78fcef Compare June 10, 2026 19:17
@nicolaskagami nicolaskagami changed the title [bgp] add networking_bgp_config_update endpoint [bgp-config] add networking_bgp_config_update endpoint Jun 11, 2026
@nicolaskagami nicolaskagami marked this pull request as ready for review June 11, 2026 21:56
@nicolaskagami

nicolaskagami commented Jun 12, 2026

Copy link
Copy Markdown
Author

(This is my first PR as an Oxide employee, so I'm still learning the ropes)

This was made drawing from Levon's old PR and the neighboring bgp-config methods. I changed a couple of things to improve readability (e.g. repeated code, some clone()s) and introduced the use of IdentityMetadataUpdateParams, which seems to be standard.

I also didn't attempt to remove the vrf field from the create / etc, as that might have other implications. Would we like to deprecate it first? Should we jump straight to failing vrf-containing calls?

Lastly, I wrote a little unit test mostly because it simply pains me not to do it. It was great because I found a (rather innocuous) bug on bgp_config_get (#10609) and learned some more about how things work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need networking_bgp_config_update endpoint

1 participant