Skip to content

ci(alloc): add formatter to just allocs#21957

Open
overlookmotel wants to merge 1 commit intomainfrom
om/04-29-ci_alloc_add_formatter_to_just_allocs_
Open

ci(alloc): add formatter to just allocs#21957
overlookmotel wants to merge 1 commit intomainfrom
om/04-29-ci_alloc_add_formatter_to_just_allocs_

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 29, 2026

Add formatter to just allocs (measure allocations).

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 29, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review April 29, 2026 19:06
Copilot AI review requested due to automatic review settings April 29, 2026 19:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the memory-allocation tracking task (cargo allocs / just allocs) to include oxc_formatter, so formatter allocations are captured alongside parser/semantic/transformer/minifier metrics.

Changes:

  • Add oxc_formatter to the allocation tracking run, including a dedicated warm-up and measured pass.
  • Generate and write a new snapshot file: allocs_formatter.snap.
  • Add oxc_formatter as a dependency of tasks/track_memory_allocations.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tasks/track_memory_allocations/src/lib.rs Adds formatter warm-up + measurement by re-parsing with formatter-specific parse options and snapshotting results.
tasks/track_memory_allocations/allocs_formatter.snap New snapshot capturing formatter allocation stats for the “complicated” fixture set.
tasks/track_memory_allocations/Cargo.toml Adds oxc_formatter workspace dependency.
Cargo.lock Records the new transitive dependency for the task crate.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 29, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-29-ci_alloc_add_formatter_to_just_allocs_ (807e625) with main (024c390)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (c731a8b) during the generation of this report, so 024c390 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel force-pushed the om/04-29-ci_alloc_add_formatter_to_just_allocs_ branch from 6ec43fc to 807e625 Compare April 29, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants