Add pull to refresh in space members list #4773#4801
Open
rohan-jadhav-dev wants to merge 1 commit intoowncloud:masterfrom
Open
Add pull to refresh in space members list #4773#4801rohan-jadhav-dev wants to merge 1 commit intoowncloud:masterfrom
rohan-jadhav-dev wants to merge 1 commit intoowncloud:masterfrom
Conversation
Collaborator
|
hi @rohan-jadhav-dev !! you can apply here the 4800 learnings to improve and be alligned with the repo structure and merging requirements. In this PR, our static code analyzer (Detekt) is also red ❌ . By checking the log, this is the problem:
There is one function that overflows the maximum number of lines (100), so, that needs some refactor. Let us know if you need help with that or any other task. Detekt is a required check to pass for merging. Thanks for your engagement!! |
c3adf72 to
01230a9
Compare
01230a9 to
df25ba6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4773
Changes
Testing
Screenshots
refresh.action.Video.mp4