Skip to content

Add pull to refresh in space members list #4773#4801

Open
rohan-jadhav-dev wants to merge 1 commit intoowncloud:masterfrom
rohan-jadhav-dev:fix/pull-to-refresh-space-members-4773
Open

Add pull to refresh in space members list #4773#4801
rohan-jadhav-dev wants to merge 1 commit intoowncloud:masterfrom
rohan-jadhav-dev:fix/pull-to-refresh-space-members-4773

Conversation

@rohan-jadhav-dev
Copy link

Summary

Fixes #4773

Changes

  • Wrapped NestedScrollView with SwipeRefreshLayout in members_fragment.xml
  • Added pull to refresh listener in SpaceMembersFragment.kt
  • Refresh spinner shows when loading
  • Spinner disappears when loading is complete

Testing

  • Opened Space members list
  • Pulled down on the list
  • Refresh spinner appeared
  • List reloaded without navigating away
  • Spinner disappeared after loading

Screenshots

refresh.action.Video.mp4

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 6, 2026

hi @rohan-jadhav-dev !! you can apply here the 4800 learnings to improve and be alligned with the repo structure and merging requirements.

In this PR, our static code analyzer (Detekt) is also red ❌ . By checking the log, this is the problem:

/home/runner/work/android/android/owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt:174:17: The function subscribeToViewModels is too long (103). The maximum length is 100. [LongMethod]

There is one function that overflows the maximum number of lines (100), so, that needs some refactor. Let us know if you need help with that or any other task. Detekt is a required check to pass for merging.

Thanks for your engagement!!

@rohan-jadhav-dev rohan-jadhav-dev force-pushed the fix/pull-to-refresh-space-members-4773 branch from c3adf72 to 01230a9 Compare March 6, 2026 17:21
@rohan-jadhav-dev rohan-jadhav-dev force-pushed the fix/pull-to-refresh-space-members-4773 branch from 01230a9 to df25ba6 Compare March 6, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Pull to refresh in the member list

2 participants