🎉 static viz: population over the long run#5602
🎉 static viz: population over the long run#5602veronikasamborska1994 merged 9 commits intomasterfrom
Conversation
|
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ✅ No differences foundAutomatically updated datasets matching excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2026-02-02 15:07:16 UTC |
e589b82 to
dcaa439
Compare
lucasrodes
left a comment
There was a problem hiding this comment.
Thanks, Veronika! Left some comments. Let me know if you need more feedback / clarifications.
Overall I think that the code is not up to ETL standards at the moment. I'd suggest dropping the hardcoded catalog paths, and possibly simplifying some bits here and there.
Again, let me know if you need any more reviews! Happy to help.
etl/steps/export/static_viz/population/2026-02-02/world_population_long_run.py
Outdated
Show resolved
Hide resolved
etl/steps/export/static_viz/population/2026-02-02/world_population_long_run.py
Outdated
Show resolved
Hide resolved
etl/steps/export/static_viz/population/2026-02-02/world_population_long_run.py
Outdated
Show resolved
Hide resolved
etl/steps/export/static_viz/population/2026-02-02/world_population_long_run.py
Outdated
Show resolved
Hide resolved
etl/steps/export/static_viz/population/2026-02-02/world_population_long_run.py
Outdated
Show resolved
Hide resolved
etl/steps/export/static_viz/population/2026-02-02/world_population_long_run.py
Outdated
Show resolved
Hide resolved
etl/steps/export/static_viz/population/2026-02-02/world_population_long_run.py
Outdated
Show resolved
Hide resolved
etl/steps/export/static_viz/population/2026-02-02/world_population_long_run.py
Outdated
Show resolved
Hide resolved
etl/steps/export/static_viz/population/2026-02-02/world_population_long_run.py
Outdated
Show resolved
Hide resolved
etl/steps/export/static_viz/population/2026-02-02/world_population_long_run.py
Outdated
Show resolved
Hide resolved
lucasrodes
left a comment
There was a problem hiding this comment.
Thanks, Veronika! Left some comments. Let me know if you need more feedback / clarifications.
Overall I think that the code is not up to ETL standards at the moment. I'd suggest dropping the hardcoded catalog paths, and possibly simplifying some bits here and there.
Again, let me know if you need any more reviews! Happy to help.
No description provided.